Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AWS IAM trusted identity entity_tags.<key> #14727

Merged
merged 2 commits into from Nov 29, 2022
Merged

Fix AWS IAM trusted identity entity_tags.<key> #14727

merged 2 commits into from Nov 29, 2022

Conversation

conradkleinespel
Copy link
Contributor

@conradkleinespel conradkleinespel commented Sep 23, 2022 •
edited

Description

The documentation for AWS IAM's trusted identity entity_tags.<key> is wrong.

Testing & Reproduction steps

n/a

Links

https://developer.hashicorp.com/consul/docs/security/acl/auth-methods/aws-iam

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@conradkleinespel conradkleinespel requested a review from a team as a code owner September 23, 2022 08:55
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Sep 23, 2022
trujillo-adam
trujillo-adam approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Nov 23, 2022
@conradkleinespel
Copy link
Contributor Author

@trujillo-adam Anything I need to do to get this merged?

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Nov 27, 2022
@trujillo-adam trujillo-adam added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs-cherrypick labels Nov 29, 2022
@trujillo-adam trujillo-adam merged commit b168b5c into hashicorp:main Nov 29, 2022
27 of 30 checks passed
This was referenced Nov 29, 2022
Merged
Merged
@conradkleinespel conradkleinespel deleted the patch-1 branch November 29, 2022 20:35
jmurret pushed a commit that referenced this pull request Dec 2, 2022
@conradkleinespel @trujillo-adam @jmurret
Fix AWS IAM trusted identity entity_tags.<key> (#14727)
4f9363e 
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trujillo-adam trujillo-adam trujillo-adam approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@conradkleinespel @trujillo-adam